Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define manifest objects examples in code #477

Merged
merged 19 commits into from
Jul 8, 2024

Conversation

nieomylnieja
Copy link
Collaborator

@nieomylnieja nieomylnieja commented Jul 1, 2024

Motivation

We're currently lacking in examples for our v1alpha objects.
This PR covers that hole by adding utilities for generating these examples and verifying them.

Release Notes

Added extended examples to the v1alpha objects with different configuration variants.

@n9-machine-user n9-machine-user added enhancement New feature or request go minor labels Jul 1, 2024
@nieomylnieja nieomylnieja marked this pull request as ready for review July 3, 2024 10:13
@daniel-zelazny
Copy link
Contributor

/build

Copy link
Contributor

@daniel-zelazny daniel-zelazny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

@nieomylnieja nieomylnieja merged commit 9732f54 into main Jul 8, 2024
5 checks passed
@nieomylnieja nieomylnieja deleted the define-manifest-objects-examples-in-code branch July 8, 2024 09:37
renovate bot added a commit to nobl9/sloctl that referenced this pull request Jul 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/nobl9/nobl9-go](https://togithub.com/nobl9/nobl9-go) |
`v0.83.0-rc3` -> `v0.83.0-rc4` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fnobl9%2fnobl9-go/v0.83.0-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fnobl9%2fnobl9-go/v0.83.0-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fnobl9%2fnobl9-go/v0.83.0-rc3/v0.83.0-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fnobl9%2fnobl9-go/v0.83.0-rc3/v0.83.0-rc4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary>

###
[`v0.83.0-rc4`](https://togithub.com/nobl9/nobl9-go/releases/tag/v0.83.0-rc4)

[Compare
Source](https://togithub.com/nobl9/nobl9-go/compare/v0.83.0-rc3...v0.83.0-rc4)

#### What's Changed

- feat: Define manifest objects examples in code by
[@&#8203;nieomylnieja](https://togithub.com/nieomylnieja) in
[nobl9/nobl9-go#477
- chore: Add Alert Method e2e tests by
[@&#8203;nieomylnieja](https://togithub.com/nieomylnieja) in
[nobl9/nobl9-go#481
- chore: Update module github.com/aws/aws-sdk-go to v1.54.16 by
[@&#8203;renovate](https://togithub.com/renovate) in
[nobl9/nobl9-go#487
- chore: Add v1alpha RoleBinding e2e tests by
[@&#8203;nieomylnieja](https://togithub.com/nieomylnieja) in
[nobl9/nobl9-go#486
- chore: Add Alert Method e2e tests by
[@&#8203;nieomylnieja](https://togithub.com/nieomylnieja) in
[nobl9/nobl9-go#488
- chore: Update module github.com/aws/aws-sdk-go to v1.54.17 by
[@&#8203;renovate](https://togithub.com/renovate) in
[nobl9/nobl9-go#489
- feat: PC-13045 Good total single query experimental support by
[@&#8203;marcinlawnik](https://togithub.com/marcinlawnik) in
[nobl9/nobl9-go#458

**Full Changelog**:
nobl9/nobl9-go@v0.83.0-rc3...v0.83.0-rc4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/nobl9/sloctl).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnb2xhbmciLCJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants