Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct string replacement in Docker e2e tests #159

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

nieomylnieja
Copy link
Contributor

We need to replace the string instead of trimming prefix as we receive the whole image not just the tag.

Testing

SLOCTL_E2E_DOCKER_TEST_IMAGE=nobl9/sloctl:v0.3.3 make test/go/e2e-docker

@nieomylnieja nieomylnieja merged commit c94f0d4 into main Jul 8, 2024
5 checks passed
@nieomylnieja nieomylnieja deleted the fix-docker-e2e-tests branch July 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants