Update ci-win.yml (#1503)

* Update ci-win.yml * fix building with C++20 in MSVC * don't cancel other jobs when one job fails --------- Co-authored-by: Vladimir Morozov <[email protected]>
nodejs · May 27, 2024 · 57ba3df · 57ba3df
1 parent 7c79c33
commit 57ba3df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml
@@ -13,11 +13,12 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        node-version: [ 18.x, 20.x, 21.x ]
+        node-version: [ 18.x, 20.x, 21.x, 22.x ]
         architecture: [x64, x86]
         os:
           - windows-2019
           - windows-2022
+      fail-fast: false  # Don't cancel other jobs when one job fails
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6

diff --git a/napi-inl.h b/napi-inl.h
@@ -154,7 +154,10 @@ napi_value TemplatedCallback(napi_env env,
                              napi_callback_info info) NAPI_NOEXCEPT {
   return details::WrapCallback([&] {
     CallbackInfo cbInfo(env, info);
-    return Callback(cbInfo);
+    // MSVC requires to copy 'Callback' function pointer to a local variable
+    // before invoking it.
+    auto callback = Callback;
+    return callback(cbInfo);
   });
 }