Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: auto deploy redirect updates to production #101

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Dec 2, 2023

As of now updates to src/constants/redirectLinks.json are being automatically merged into main, however they're only being automatically deployed to staging. We still need to manually deploy the change to production in order for it to take effect

For reference the last time the worker updated the redirects here https://github.com/nodejs/release-cloudflare-worker/actions/runs/7040199325/job/19160694531 and when I deployed to prod here https://github.com/nodejs/release-cloudflare-worker/actions/runs/7042036821/job/19165548546

There is also a way we can do this without needing to run the action twice. Here

if: github.event_name == 'workflow_dispatch'
we could check if the commit is from the @nodejs-github-bot user and/or if the commit is titled chore: update redirect links

As of now updates to `src/constants/redirectLinks.json` are being automatically merged into `main`, however they're only being automatically deployed to staging. We still need to manually
deploy the change to production in order for it to take effect

For reference the last time the worker updated the redirects here https://github.com/nodejs/release-cloudflare-worker/actions/runs/7040199325/job/19160694531
and when I deployed to prod here https://github.com/nodejs/release-cloudflare-worker/actions/runs/7042036821/job/19165548546
@flakey5 flakey5 requested a review from MoLow December 2, 2023 20:08
@flakey5 flakey5 requested a review from a team as a code owner December 2, 2023 20:08
@flakey5 flakey5 merged commit a262491 into main Dec 3, 2023
3 checks passed
@flakey5 flakey5 deleted the flakey5/20231203/prod-deploy branch December 3, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants