Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use double quotes in directory listing html #76

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Nov 15, 2023

No description provided.

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but the PR/commit title is wrong -- the change is to use double quotes.

@ovflowd ovflowd changed the title fix: use single quotes in directory listing html fix: use double quotes in directory listing html Nov 15, 2023
@ovflowd
Copy link
Member

ovflowd commented Nov 15, 2023

@flakey5 shouldn't the test snapshot be updated? Also, hmmm, there's no EOF (line) on the template, can you add one?

@ovflowd ovflowd merged commit 0e9ec8b into main Nov 15, 2023
3 checks passed
@ovflowd ovflowd deleted the flakey5/20231115/quotes branch November 15, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants