src: include error message when reporting failed R2 operations to sentry #82
Conversation
| @@ -56,17 +56,21 @@ async function r2GetWithRetries( | |||
| key: string, | |||
| options?: R2GetOptions | |||
| ): Promise<R2Object | null> { | |||
| let r2Error: unknown = undefined; | |||
There was a problem hiding this comment.
| let r2Error: unknown = undefined; | |
| let r2Error: Error; |
And no need to assign to undefined
There was a problem hiding this comment.
In a try/catch block whatever was thrown has the type of undefined though?
There was a problem hiding this comment.
Hmm?
I mean that the default value of a let assignment will be undefined, and the type of err on catch in general is Error even if it might not during runtime
There was a problem hiding this comment.
At least with the types I have the err type in a catch block is unknown, to get it to an Error we'd need to cast it
flakey5
force-pushed
the
flakey5/20231118/retry-errors
branch
from
a6b9c52
to
7f9ae9b
Compare
|
@flakey5 I saw you didnt remove the undefined assignments? |
Agh, the second time within a 24 hour period of not saving a file before committing it. I'll remove them later on in another pr for some code cleanup |
|
All good 🫶 |
No description provided.