-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove wc session on reconnect forget #1255
base: dev
Are you sure you want to change the base?
Conversation
Current coverage reportSummary
Tests which was executed
Coverage by files (0%)
|
Jest Unit tests resultsDuration: 74.334 seconds
Outcome: Passed | Total Tests: 372 | Passed: 368 | Failed: 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions
forward({ from: sessionTopicUpdated, to: sessionTopicUpdatedFx }); | ||
sample({ | ||
clock: sessionTopicUpdated, | ||
source: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source: $client
@@ -367,18 +381,29 @@ sample({ | |||
target: disconnectFx, | |||
}); | |||
|
|||
forward({ from: disconnectFx.done, to: reset }); | |||
|
|||
sample({ clock: disconnectFx.done, fn: ({ params }) => params, target: removeSessionFx }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To increase readability
By the way, can we use forward
here?
sample({
clock: disconnectFx.done,
fn: ({ params }) => params,
target: removeSessionFx,
});
Wallet connect fixes
client.session.delete
on session forget