-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @withoutGlobalScopes
directive
#2577
Add @withoutGlobalScopes
directive
#2577
Conversation
Hello |
Eventually, yeah. Let's make sure it is properly described first. |
tests/database/migrations/2024_06_29_000000_create_episodes_table.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedikt Franke <[email protected]>
Co-authored-by: Benedikt Franke <[email protected]>
Co-authored-by: Benedikt Franke <[email protected]>
Co-authored-by: Benedikt Franke <[email protected]>
Co-authored-by: Benedikt Franke <[email protected]>
Thanks again, new commit pushed ...check the doc file please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know when all comments are addressed.
There is a typo in the title, and tests are failing. |
Can you give me more details about the test error? |
You can look at the results in https://github.com/nuwave/lighthouse/actions/runs/9746838503. |
Ok..., I pushed another commit...hope will be succeed |
You don't have to hope, you can run the tests locally. See https://github.com/nuwave/lighthouse/blob/master/CONTRIBUTING.md. Please let me know when every comment has been addressed and CI passes. |
|
Finally, I tested locally and both tests were successful. |
There are still plenty of unresolved discussions. Please address them all. |
please check them |
tests/Integration/Schema/Directives/WithoutGlobalScopesDirectiveTest.php
Outdated
Show resolved
Hide resolved
NEW COMMIT PUSHED |
I am a bit irritated by your use of ALL CAPS. Anyways, thanks for making the requested changes. I think I failed to communicate how I would like certain things to be done very specifically. The intent of your changes is clear, so I am going to go ahead and make smaller changes, I think that will be more efficient than going back and forth. |
@withoutGlobalScopes
directive
add @withoutGlobalScopes directive which works on argument to ignore global scopes that are defined in the model.
type Query {
posts
(
allPosts (Bool @withoutGlobalScopes (names : ["scheduled"])
)
}