Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

second part of store tests conversion to kotlin #357

Open
wants to merge 2 commits into
base: feature/kotlin_conversion
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
package com.nytimes.android.external.store3

import com.nytimes.android.external.store3.base.impl.BarCode
import com.nytimes.android.external.store3.base.impl.Store
import com.nytimes.android.external.store3.base.impl.StoreBuilder
import io.reactivex.Maybe
import io.reactivex.Single
import org.assertj.core.api.Assertions.assertThat
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mock
import org.mockito.Mockito.`when`
import org.mockito.runners.MockitoJUnitRunner
import java.util.concurrent.atomic.AtomicInteger

@RunWith(MockitoJUnitRunner::class)
class GetRefreshingTest {
@Mock
internal lateinit var persister: ClearingPersister
internal lateinit var networkCalls: AtomicInteger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be private?

private lateinit var store: Store<Int, BarCode>

@Before
fun setUp() {
networkCalls = AtomicInteger(0)
store = StoreBuilder.barcode<Int>()
.fetcher { barCode -> Single.fromCallable { networkCalls.incrementAndGet() } }
.persister(persister)
.open()
}

@Test
fun testRefreshOnClear() {
val barcode = BarCode("type", "key")
`when`(persister.read(barcode))
.thenReturn(Maybe.empty()) //read from disk
.thenReturn(Maybe.just(1)) //read from disk after fetching from network
.thenReturn(Maybe.empty()) //read from disk after clearing disk cache
.thenReturn(Maybe.just(1)) //read from disk after making additional network call
`when`(persister.write(barcode, 1)).thenReturn(Single.just(true))
`when`(persister.write(barcode, 2)).thenReturn(Single.just(true))


val refreshingObservable = store.getRefreshing(barcode).test()
refreshingObservable.assertValueCount(1)
assertThat(networkCalls.toInt()).isEqualTo(1)
//clearing the store should produce another network call
store.clear(barcode)
refreshingObservable.assertValueCount(2)
assertThat(networkCalls.toInt()).isEqualTo(2)

store.get(barcode).test().awaitTerminalEvent()
refreshingObservable.assertValueCount(2)
assertThat(networkCalls.toInt()).isEqualTo(2)
}

@Test
fun testRefreshOnClearAll() {
val barcode1 = BarCode("type", "key")
val barcode2 = BarCode("type", "key2")

`when`(persister.read(barcode1))
.thenReturn(Maybe.empty()) //read from disk
.thenReturn(Maybe.just(1)) //read from disk after fetching from network
.thenReturn(Maybe.empty()) //read from disk after clearing disk cache
.thenReturn(Maybe.just(1)) //read from disk after making additional network call
`when`(persister.write(barcode1, 1)).thenReturn(Single.just(true))
`when`(persister.write(barcode1, 2)).thenReturn(Single.just(true))

`when`(persister.read(barcode2))
.thenReturn(Maybe.empty()) //read from disk
.thenReturn(Maybe.just(1)) //read from disk after fetching from network
.thenReturn(Maybe.empty()) //read from disk after clearing disk cache
.thenReturn(Maybe.just(1)) //read from disk after making additional network call

`when`(persister.write(barcode2, 1)).thenReturn(Single.just(true))
`when`(persister.write(barcode2, 2)).thenReturn(Single.just(true))

val testObservable1 = store.getRefreshing(barcode1).test()
val testObservable2 = store.getRefreshing(barcode2).test()
testObservable1.assertValueCount(1)
testObservable2.assertValueCount(1)

assertThat(networkCalls.toInt()).isEqualTo(2)

store.clear()
assertThat(networkCalls.toInt()).isEqualTo(4)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ class KeyParserTest {
}

companion object {

private const val NETWORK = "Network"
val KEY = 5
private const val KEY = 5
}
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
package com.nytimes.android.external.store3

import com.nytimes.android.external.store3.base.Fetcher
import com.nytimes.android.external.store3.base.Parser
import com.nytimes.android.external.store3.base.Persister
import com.nytimes.android.external.store3.base.impl.BarCode
import com.nytimes.android.external.store3.base.impl.ParsingFetcher
import com.nytimes.android.external.store3.base.impl.StoreBuilder
import io.reactivex.Maybe
import io.reactivex.Single
import org.assertj.core.api.Assertions.assertThat
import org.junit.Before
import org.junit.Test
import org.mockito.Mock
import org.mockito.Mockito.`when`
import org.mockito.Mockito.times
import org.mockito.Mockito.verify
import org.mockito.MockitoAnnotations

class ParsingFetcherTest {

@Mock
internal lateinit var fetcher: Fetcher<String, BarCode>
@Mock
internal lateinit var parser: Parser<String, String>
@Mock
internal lateinit var persister: Persister<String, BarCode>
private val barCode = BarCode("key", "value")

@Before
fun setUp() {
MockitoAnnotations.initMocks(this)
}

@Test
fun testPersistFetcher() {

val simpleStore = StoreBuilder.barcode<String>()
.fetcher(ParsingFetcher.from(fetcher, parser))
.persister(persister)
.open()

`when`(fetcher.fetch(barCode))
.thenReturn(Single.just(RAW_DATA))

`when`(parser.apply(RAW_DATA))
.thenReturn(PARSED)

`when`(persister.read(barCode))
.thenReturn(Maybe.just(PARSED))

`when`(persister.write(barCode, PARSED))
.thenReturn(Single.just(true))

val value = simpleStore.fetch(barCode).blockingGet()

assertThat(value).isEqualTo(PARSED)

verify<Fetcher<String, BarCode>>(fetcher, times(1)).fetch(barCode)
verify<Parser<String, String>>(parser, times(1)).apply(RAW_DATA)
verify<Persister<String, BarCode>>(persister, times(1)).write(barCode, PARSED)
}

companion object {
private const val RAW_DATA = "Test data."
private const val PARSED = "DATA PARSED"
}
}
Loading