Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SRID value variable #1937

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Deprecate SRID value variable #1937

merged 10 commits into from
Jun 26, 2024

Conversation

ralfhandl
Copy link
Contributor

Fixes #1935

sthagen
sthagen approved these changes May 17, 2024
View reviewed changes
Copy link

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot. Much appreciated.

HeikoTheissen
HeikoTheissen requested changes May 21, 2024
View reviewed changes
odata-csdl/1 Introduction.md Outdated Show resolved Hide resolved
odata-json-format/1 Introduction.md Show resolved Hide resolved
HeikoTheissen
HeikoTheissen previously approved these changes May 21, 2024
View reviewed changes
@ralfhandl
Copy link
Contributor Author

Rebuilt after merging main

sthagen
sthagen approved these changes Jun 13, 2024
View reviewed changes
Copy link

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

sthagen
sthagen approved these changes Jun 20, 2024
View reviewed changes
Copy link

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting better all the time. Thanks.

ralfhandl
ralfhandl commented Jun 26, 2024
View reviewed changes
odata-csdl/1 Introduction.md Outdated
Comment on lines 816 to 817
Services SHOULD NOT use the special value `variable` as, for example, the [OData-JSON](#ODataJSON)
format does not define a representation for instance-specific spatial reference systems.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Services SHOULD NOT use the special value `variable` as, for example, the [OData-JSON](#ODataJSON)
format does not define a representation for instance-specific spatial reference systems.
Services SHOULD NOT use the special value `variable` as some formats, for example [OData-JSON](#ODataJSON), do not define a representation for instance-specific spatial reference systems.

@ralfhandl ralfhandl requested a review from sthagen June 26, 2024 15:42
@ralfhandl ralfhandl merged commit 0db3c94 into main Jun 26, 2024
1 check passed
@ralfhandl ralfhandl deleted the 1935-SRID-value-variable branch June 26, 2024 15:42
mikepizzo
mikepizzo reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@mikepizzo mikepizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that the reference to ODATA-JSON is required, but okay if others feel strongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikepizzo mikepizzo mikepizzo left review comments

@HeikoTheissen HeikoTheissen HeikoTheissen approved these changes

@sthagen sthagen Awaiting requested review from sthagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSDL: deprecate SRID value "variable"
4 participants
@ralfhandl @sthagen @mikepizzo @HeikoTheissen