Don't show TX error messages for empty error blocks

oasisprotocol · Jun 5, 2024 · f7c66a2 · f7c66a2
1 parent f9b0642
commit f7c66a2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.changelog/1444.trivial.md b/.changelog/1444.trivial.md
@@ -0,0 +1 @@
+Don't show TX error messages for empty error blocks
diff --git a/src/app/components/StatusIcon/index.tsx b/src/app/components/StatusIcon/index.tsx
@@ -92,7 +92,7 @@ export const StatusIcon: FC<StatusIconProps> = ({ success, error, withText }) =>
           &nbsp;
           {statusIcon[status]}
         </StyledBox>
-        {error && <ErrorBox>{errorMessage}</ErrorBox>}
+        {errorMessage && <ErrorBox>{errorMessage}</ErrorBox>}
       </>
     )
   } else {

diff --git a/src/app/hooks/useTxErrorMessage.ts b/src/app/hooks/useTxErrorMessage.ts
@@ -3,7 +3,7 @@ import { TxError } from '../../oasis-nexus/api'
 
 export const useTxErrorMessage = (error: TxError | undefined): string | undefined => {
   const { t } = useTranslation()
-  if (!error) return undefined
+  if (!error || (!error.module && !error.code)) return undefined
   if (error.module === 'evm' && error.code === 8 && !error.message) {
     // EVM reverted, with missing error message
     return `${t('errors.revertedWithoutMessage')} (${t('errors.code')} ${error.code})`