Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch to be used as a base for the PontusX browser #1355

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Mar 31, 2024

This branch is always rebased to latest master, with all the fixes and enhancements.

This is supposed to be used for all future PontusX work.

Copy link

github-actions bot commented Mar 31, 2024

Deployed to Cloudflare Pages

Latest commit: 611ce3f87080a21697f71b09e8856cbe3de9c0a0
Status:✅ Deploy successful!
Preview URL: https://8b3795a8.oasis-explorer.pages.dev

.env Show resolved Hide resolved
@csillag csillag force-pushed the csillag/pontusx branch 3 times, most recently from 812cf66 to 82bbed0 Compare April 30, 2024 19:59
@csillag
Copy link
Contributor Author

csillag commented Apr 30, 2024

This has now been rebased to the latest master.

@csillag csillag force-pushed the csillag/pontusx branch 4 times, most recently from 0144b96 to f01421c Compare April 30, 2024 21:28
@csillag csillag force-pushed the csillag/pontusx branch 4 times, most recently from 1e9d457 to 76065e2 Compare May 29, 2024 14:20
@csillag csillag force-pushed the csillag/pontusx branch 2 times, most recently from ae96b12 to 8ef8cf9 Compare June 3, 2024 14:39
@csillag csillag force-pushed the csillag/pontusx branch 4 times, most recently from d4a1b56 to ee29f0d Compare June 5, 2024 12:52
Normally, the name of a scope is derived by concatenating
the name of the layer (i.e. "Sapphire") and
the name of the network (i.e. "Testnet") ==> "Sapphire Testnet"

However, in some specific cases, we might want to have something different.
This can be achieved by this override function.
Normally the "sapphire" paratime on the "testnet" network will be
available via "testnet/sapphire".

This commit adds a config option to override the paths for
specific paratimes with any two-word constant.

(So that we can use "magic/kingdom" instead of "testnet/sapphire",
if we want to.)
This is mostly useful if we want to restrict a deployment
to display only a few layers.
Up to now, this function has returned all the themes, for all networks.
Now it will only return one theme, for the requested network.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants