Rename transform to rewrite #369
Open
+38
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deemp
reviewed
May 24, 2024
site/docs/src/pipeline.md
Outdated
| The `pipeline/config.yaml` file specifies how original `EO` programs are transformed into initial `EO` programs. | ||
| Transformation is necessary because some objects in original `EO` programs don't work. | ||
| The `pipeline/config.yaml` file specifies how original `EO` programs are rewriteed into initial `EO` programs. | ||
| Rewriteation is necessary because some objects in original `EO` programs don't work. |
There was a problem hiding this comment.
All these (funny) changes in this file should be removed because this file doesn't use the CLI commands terminology.
There was a problem hiding this comment.
No problem. Just remove all changes to this file.
deemp
reviewed
May 24, 2024
site/docs/src/pipeline.md
Outdated
| The `pipeline/config.yaml` file specifies how original `EO` programs are rewriteed into initial `EO` programs. | ||
| Rewriteation is necessary because some objects in original `EO` programs don't work. | ||
| The `pipeline/config.yaml` file specifies how original `EO` programs are rewrote into initial `EO` programs. | ||
| Rewriting is necessary because some objects in original `EO` programs don't work. |
|
Additionally, I'd suggest you:
|
aabounegm
approved these changes
May 27, 2024
deemp
force-pushed
the
rename-transform-to-rewrite
branch
from
9361be1
to
cf750b6
Compare
|
@RoukayaZaki, please resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #169
PR-Codex overview
The focus of this PR is to rename a command from
normalizer transformtonormalizer rewriteand update related documentation and command line options.Detailed summary
normalizer transformcommand tonormalizer rewritenormalizer rewritenormalizer rewritecommand