[new release] uri, uri-sexp, uri-re and uri-bench (4.4.0) #24522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: * **breaking change** Fix parsing & printing of IPv6 addresses in the host part of an uri If we follow the RFC3986 correctly, IPv6 must be surrounded by '[' and ']'. Old versions of `ocaml-uri` escaped these characters. The new version interprets these characters to recognize an IPv6 address. Users should take note of this change in behaviour, which fixes a number of bugs in HTTP requests. (@anmonteiro, review by several maintainers, mirage/ocaml-uri#169) * Upgrade tests to `ounit2` (@Alessandro-Barbieri, mirage/ocaml-uri#161)
hannesm
reviewed
Sep 25, 2023
hannesm
reviewed
Sep 25, 2023
hannesm
reviewed
Sep 25, 2023
hannesm
reviewed
Sep 25, 2023
|
I look into failures and they are unrelated to this release even if we have a breaking change. Moreover, I did a check about reverse-dependencies and nobody expects something related to IPv6. A annoucement will be done after this merge to inform people about our breaking change. But we can consider to merge it! |
|
Thanks. I think I can fix some failures but they are unrelated, I will fix them separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An RFC3986 URI/URL parsing library
CHANGES:
breaking change Fix parsing & printing of IPv6 addresses in the host part of an uri
If we follow the RFC3986 correctly, IPv6 must be surrounded by '[' and ']'. Old versions
of
ocaml-uriescaped these characters. The new version interprets these characters torecognize an IPv6 address.
Users should take note of this change in behaviour, which fixes a number of bugs in HTTP
requests. (@anmonteiro, review by several maintainers, fix parsing / printing of IPv6 addresses in URIs mirage/ocaml-uri#169)
Upgrade tests to
ounit2(@Alessandro-Barbieri, use ounit2 mirage/ocaml-uri#161)