Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slackbridge crash above 500 users #109

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Fix slackbridge crash above 500 users #109

merged 1 commit into from
Nov 8, 2020

Conversation

jvperrin
Copy link
Member

@jvperrin jvperrin commented Nov 8, 2020

This adds some pagination for the conversations.members call in particular, but more general pagination is available in slackclient 2.x which we are not on yet (#78), and might never upgrade to if this project goes away (#107).

Copy link
Member

@nikhiljha nikhiljha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean its already broken so this can't really break it more

@jvperrin jvperrin merged commit 179f7c6 into ocf:master Nov 8, 2020
@jvperrin jvperrin deleted the fix-slackbridge-crash-above-500-members branch November 8, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants