Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage drop introduced by UI / UX enhancements #56

Open
3 of 4 tasks
Rkareko opened this issue Nov 24, 2022 · 0 comments
Open
3 of 4 tasks

Fix coverage drop introduced by UI / UX enhancements #56

Rkareko opened this issue Nov 24, 2022 · 0 comments

Comments

@Rkareko
Copy link
Contributor

Rkareko commented Nov 24, 2022

  • Get coverage to >70%
  • Fix issue causing coveralls not to include coverage for compose tests

These issues are linked to PR #59

Troubleshooting
A github action was added to upload the test artifacts.

  • name: Upload Jacoco artifacts
    uses: actions/upload-artifact@v3
    with:
    name: test-artifacts
    path: |
    p2p-lib/build/reports/
    p2p-lib/build/outputs/unit_test_code_coverage/
    p2p-lib/build/outputs/code_coverage/
    p2p-lib/build/outputs/androidTest-results/
    It emerged that the p2p-lib/build/outputs/code_coverage/ was not being generated, which is the reason that the instrumented (compose) test coverage is not reported by Jacoco.

Potential fix
After running only compose tests and disabling ANDROIDX_TEST_ORCHESTRATOR option in the build.gradle file compose test coverage was uploaded

We hit the github actions billing limit before testing whether this fix works when both unit and instrumented tests were enabled.

Next steps

  • Run CI build next time the billing limit is reset to see whether the above fix worked for the combined test suite
  • Remove the action for uploading the test artifacts
@Rkareko Rkareko mentioned this issue May 18, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant