Update the P2P data UI and workflow #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial P2P event, screen and UI state classes
Add action button
Update spacing between progress status components
|
Still WIP |
ekigamba
approved these changes
Nov 22, 2022
|
@dubdabasoduba @ekigamba @f-odhiambo I propose we merge this work since any other PRs need to be based on it. The tests coverage issue can be tracked on Fix coverage drop introduced by UI / UX enhancements |
Sounds good |
ellykits
requested changes
Nov 24, 2022
| view.requestLocationPermissionsAndEnableLocation() | ||
| } | ||
| is P2PEvent.PairDevicesFound -> { | ||
| // display list of pairing devices |
| ) | ||
| Column(modifier = modifier.wrapContentWidth(Alignment.Start)) { | ||
| Text( | ||
| text = "${device?.name()} Phone", |
| ) | ||
| Column(modifier = modifier.wrapContentWidth(Alignment.Start)) { | ||
| Text( | ||
| text = "${device?.name()} Phone", |
ellykits
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes opensrp/fhircore#1728 & opensrp/fhircore#1729
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Release | Other)
Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide