121 multiple location types #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-multiple-location-types
…-multiple-location-types
…o/fhir-tooling into 121-multiple-location-types
|
Before incase there was an empty cell and no location type or physical type was input, the variables "$t_code" or "$pt_display" were passed, I have changed it to delete the columns incase no values are passed. |
Wambere
requested changes
Feb 8, 2024
|
@TraciebelWairimu let's update the documentation for this as well |
Wambere
reviewed
Feb 8, 2024
pld
previously approved these changes
Feb 8, 2024
Wambere
approved these changes
Feb 9, 2024
TraciebelWairimu
added a commit
that referenced
this pull request
Feb 13, 2024
* Change Physical_Type to type in locations_payload.json structure * Allow input of multiple location types and physical types * Avoid to pass location types and physicalType variables incase of empty cell * Allow input of multiple physicalTypes and types * Update Create locations in bulk documentation --------- Co-authored-by: Francis Odhiambo <[email protected]> Co-authored-by: Wambere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #121
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide