122 generate unique UUID #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user_resources functions
pld
reviewed
Feb 7, 2024
importer/main.py
Outdated
| @@ -139,12 +139,12 @@ def create_user_resources(user_id, user): | |||
| logging.info("Creating user resources") | |||
| # generate uuids | |||
| if len(str(user[4]).strip()) == 0: | |||
There was a problem hiding this comment.
please refactor all the code in this function by destructuring user and removing references by index.
eg.
a, b, c, d = user
pld
approved these changes
Feb 8, 2024
TraciebelWairimu
added a commit
that referenced
this pull request
Feb 13, 2024
* Change Physical_Type to type in locations_payload.json structure * Generate unique uuid for locations * Generate unique/repeatable uuid for build_org_affiliation and create_user_resources functions * Create tests to check if the generated unique_uuid is unique and repeatable * Fix the test_uuid_generated_for_locations_is_unique_and_repeatable test case * Refactor all the code in the create_user_resources function, destructure user and remove references by index * Refactor test_main.py imports * Refactor the code, destructure user and remove references by index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #122
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide