Check and Throw error when ID is Non-existent, when method is update … #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
approved these changes
Feb 14, 2024
pld
requested changes
Feb 14, 2024
importer/main.py
Outdated
Comment on lines
495
to
498
| if response[1] == 200: | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
you can simplify this to use a single return statement
Wambere
force-pushed
the
130-Throw-Error-NonExisting-ID
branch
from
74970f9
to
0bffa2b
Compare
Wambere
changed the title
|
Added a DNM until we get the tests working |
Wambere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and Test cases for the same
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #130
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide