Setup testing framework - efsity #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincmba
force-pushed
the
setup_testing_framework
branch
2 times, most recently
from
c3ba3fc
to
dafd578
Compare
lincmba
force-pushed
the
setup_testing_framework
branch
2 times, most recently
from
4b2d4cf
to
4a44f67
Compare
lincmba
commented
Nov 2, 2023
|
Looks good but I've added this item here on the ticket #73. It is about adding a CI check incase the code coverage drops. Might be a good idea to address it as part of this PR. Also okay with addressing it separately cc @lincmba |
2 tasks
ndegwamartin
reviewed
Nov 6, 2023
Update pull request template to indicate use of gradle instead on maven
- Add jacoco test coverage reports generation - Only perform spotless check
lincmba
force-pushed
the
setup_testing_framework
branch
from
b601d63
to
1f3a48e
Compare
ndegwamartin
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
Engineer Checklist
mvn spotless:applyto check my code follows the project's style guide