-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix permission prompt #378
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Pull Request Test Coverage Report for Build #620Details
💛 - Coveralls |
List<String> permissions = new ArrayList<>(); | ||
permissions.add(Manifest.permission.ACCESS_FINE_LOCATION); | ||
|
||
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.S) { | ||
permissions.add(Manifest.permission.WRITE_EXTERNAL_STORAGE); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lentumunai-Mark Do we have tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dubdabasoduba no existing tests for the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create one
Entails to resolve permission prompt for Android >= 13
for more context, please refer to the link below
Related to this issue.