Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper generator package #181

Closed
wants to merge 4 commits into from

Conversation

MaxStalker
Copy link
Collaborator

Closes #180

Description

CLI commands were using old flow-cadut generator leading to error during call.
I've fixed imports to proper library and confirmed locally that it works as intended

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker requested a review from a team as a code owner September 7, 2022 13:03
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: f0a8dcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MaxStalker
Copy link
Collaborator Author

Tests are failing within examples folder.
And it's inconsitent. It might work one time and fail on the next one 🤷‍♂️
I would recommend to exclude examples folder from running on test command.

@gregsantos
Copy link
Member

Would like to merge this @MaxStalker but was gonna ask about the failing CI. If you've identified the culprit, would you mind updating your PR?

@adbario
Copy link
Contributor

adbario commented Sep 19, 2022

@MaxStalker Likely not related, but just noticed that in utilities.test.js the basePath is passed to init() inside an object while it shouldn't be as seen in https://github.com/onflow/flow-js-testing/blob/master/src/init.js#L28 and in all the other tests.

utilities.test.js seems to be the one that failed on your latest CI run.

@MaxStalker
Copy link
Collaborator Author

@gregsantos it fails now because of issues with Github Actions 🤦‍♂️

@justinbarry
Copy link
Contributor

justinbarry commented Sep 30, 2022

Merged at part of #192. I've never been able to figure out how make direct feedback on cross repo PRs. Maybe it isn't possible. Thank you all for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize command broken in 0.3.0-alpha.15
4 participants