Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overriding default import map #230

Open
wants to merge 5 commits into
base: feature/stable-cadence
Choose a base branch
from

Conversation

NtTestAlert
Copy link

@NtTestAlert NtTestAlert commented May 17, 2024

Allow overriding defaultsByName either by explicitly setting the 0x00.. address in the import statement, by setting it to from "DYNAMIC", or by modifying the defaultsByName map (now exported)

Also including a fix for broken register-contract.cdc


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@NtTestAlert NtTestAlert requested review from MaxStalker and a team as code owners May 17, 2024 13:34
Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: f04e609

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NtTestAlert NtTestAlert force-pushed the feature/stable-cadence branch 2 times, most recently from 362b906 to e0bec29 Compare May 17, 2024 13:36
@NtTestAlert NtTestAlert changed the title Feature/stable cadence fix: allow overriding default import map May 17, 2024
@NtTestAlert NtTestAlert marked this pull request as draft May 17, 2024 14:23
@NtTestAlert NtTestAlert marked this pull request as ready for review May 17, 2024 14:33
@NtTestAlert
Copy link
Author

if the address is explicitly set it skips FlowManager.getAddress
(so setContractAddress behavior slightly changed - shouldn't be a problem tho)

so might want to change it to only expose defaultsByName if this is not desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants