Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for advanced flow.json service key types #237

Merged
merged 5 commits into from
May 24, 2024

Conversation

jribbink
Copy link
Contributor

Closes #234

Description

Adds supports for advanced keys in flow.json

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink requested review from MaxStalker and a team as code owners May 24, 2024 18:47
Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 549375a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink changed the base branch from master to feature/stable-cadence May 24, 2024 18:47
Copy link
Contributor

Dependency Testbed

  • Flow CLI: v1.18.0-cadence-v1.0.0-preview.24
  • FCL: 1.3.2

Release Version

The package containing these changes will be released with version 0.6.0-stable-cadence.3

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.14% (-1.78% 🔻)
658/730
🟡 Branches
71.53% (-3.19% 🔻)
206/288
🟢 Functions
92.31% (-0.5% 🔻)
132/143
🟢 Lines
90.83% (-1.6% 🔻)
634/698
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 flow-config.js 75% 50% 83.33% 80.95%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 init.js
60.87% (-39.13% 🔻)
52.63% (-47.37% 🔻)
100%
60.87% (-39.13% 🔻)

Test suite run success

110 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 549375a

@jribbink jribbink merged commit eceb9d6 into feature/stable-cadence May 24, 2024
2 checks passed
@jribbink jribbink deleted the jribbink/fix-file-keys branch May 24, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue using getAccountAddress
1 participant