Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stored the result of get_chat_message_history() in a variable for reuse in clear_chat_history() function #79

Closed
wants to merge 1 commit into from
Closed

Stored the result of get_chat_message_history() in a variable for reuse in clear_chat_history() function #79

wants to merge 1 commit into from

Conversation

Abhinavcode13
Copy link
Contributor

No description provided.

Mideky-hub
Mideky-hub reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Mideky-hub Mideky-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain further the relevancy of creating a variable not assiacted with a class nor an object, not returning it, assign a connection to a chat_history variable to not use it? I may be missing something 🤔

gpt_computer_assistant/agent/chat_history.py Show resolved Hide resolved
gpt_computer_assistant/agent/chat_history.py Show resolved Hide resolved
@onuratakan
Copy link
Owner

onuratakan commented Jun 7, 2024 •
edited
Loading

Thank you but not a improvement.

@onuratakan onuratakan closed this Jun 7, 2024
@Abhinavcode13
Copy link
Contributor Author

Thank you but not a improvement.

Cool, any you look at approved PR #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mideky-hub Mideky-hub Mideky-hub left review comments

Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abhinavcode13 @onuratakan @Mideky-hub