improve GGUF metadata handling #6082
Open
+116
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support GGUFv2 (previously only v3 was supported) - Support execution of big-endian GGUF files on big-endian hosts - Fail if magic bytes b'GGUF' are wrong
|
I prefer to not increase the complexity of the code base to handle upstream breaking changes in llama.cpp. If GGUFv3 is the current standard, let's stick with GGUFv3. Discarding those backward compatibility changes, are there any other modifications that you still find worth adding in this PR? |
It allows execution of big-endian gguf files on big-endian hosts, instead of only allowing files to be executed on little-endian machines EDIT: And also failing if the magic bytes |
|
Could you keep only those changes? |
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b'GGUF'are wrongtokenizer.ggml.tokens, etc for v2 and v3)Verified working with multiple GGUFv2 and v3 models
@oobabooga I hope this contribution is helpful :)