[WIP] Update autolink version for Mattermost (do not merge) #135
Conversation
| MATTERMOST_UNLINK_VERSION: 0.3.0 | ||
| # UNLINK is the autolink plugin which converts JIRA tickets to clickable URL | ||
| # https://github.com/mattermost/mattermost-plugin-autolink/releases/ | ||
| MATTERMOST_UNLINK_VERSION: 1.0.1 |
There was a problem hiding this comment.
@SSPJ, the latest version is 1.1.0 and I installed that version.
There was a problem hiding this comment.
@lgp171188 Right, this PR isn't for merging; I just pushed it so that you would have something to look at. I should have made that clear in the description, sorry!
| - name: generate autolink configuration | ||
| template: | ||
| src: autolink.json.j2 | ||
| dest: "{{ MATTERMOST_CONFIG_FILE|dirname }}/autolink.json" | ||
| dest: "{{ MATTERMOST_STATUS_DIR }}/autolink.json" |
There was a problem hiding this comment.
@SSPJ, this wasn't needed when I did the upgrade and the auto-linking works okay. So is this needed?
There was a problem hiding this comment.
No, it's just reducing some code complexity: MATTERMOST_CONFIG_FILE is "{{ MATTERMOST_STATUS_DIR }}/config.json" and so MATTERMOST_CONFIG_FILE|dirname is just MATTERMOST_STATUS_DIR.
| @@ -8,10 +8,6 @@ | |||
| { | |||
| "Pattern": "(?P<project>{{ project }})-(?P<id>\\d{1,6})(?P<comma>[,;]*)", | |||
| "Template": "[${project}-${id}](https://{{ domain.domain }}/browse/${project}-${id})${comma}" | |||
| }, | |||
There was a problem hiding this comment.
@SSPJ, I didn't see any issues with this pattern. Is there a reason for removing it?
There was a problem hiding this comment.
I can't remember why I took it out, sorry.
SSPJ
changed the title
No description provided.