chore: update README for web site inclusion #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=========================================
Coverage 95.19% 95.19%
Complexity 227 227
=========================================
Files 40 40
Lines 583 583
=========================================
Hits 555 555
Misses 28 28 ☔ View full report in Codecov by Sentry. |
toddbaert
force-pushed
the
chore/readme-update
branch
from
4251bcb
to
74f73a3
Compare
|
We may need to add a fourth status to denote features that don't make sense in a language. I think that may be the case for php. What do you think @tcarrio? |
toddbaert
commented
Oct 26, 2023
Potentially dumb question, but what feature(s) wouldn't exist in PHP... shutdown? |
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
tcarrio
reviewed
Oct 31, 2023
beeme1mr
reviewed
Oct 31, 2023
beeme1mr
reviewed
Oct 31, 2023
Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Tom Carrio <[email protected]>
Co-authored-by: Tom Carrio <[email protected]> Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Michael Beemer <[email protected]> Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
tcarrio
force-pushed
the
chore/readme-update
branch
from
ca3dfde
to
a3be183
Compare
|
Added the missing code examples, rebased on the latest main, and signed off all commits. |
tcarrio
approved these changes
Dec 5, 2023
beeme1mr
approved these changes
Dec 5, 2023
tcarrio
pushed a commit
that referenced
this pull request
Dec 17, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.4](2.0.3...2.0.4) (2023-12-05) ### 🧹 Chore * **deps:** update dependency vimeo/psalm to ~5.17.0 ([#111](#111)) ([ea4fed3](ea4fed3)) * update README for web site inclusion ([#104](#104)) ([5d393b5](5d393b5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I've tried to get everything right, but there's 5-6 code-example TODOs.
@beeme1mr feel free to make any corrections you see. Up to you if you think we can include this without the code samples.