Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added Hindi Translated Strings #2376

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

SekhGulamMainuddin
Copy link
Contributor

Fixes #2365

Added Hindi Translations for the Strings.

Please add #hacktoberfest on merge.

@PratyushSingh07
Copy link
Collaborator

please follow our commit & PR guidelines . you can go through the wiki page here

Follow the same in all of your PRs

@SekhGulamMainuddin
Copy link
Contributor Author

SekhGulamMainuddin commented Oct 13, 2023

please follow our commit & PR guidelines . you can go through the wiki page here

Follow the same in all of your PRs

Sorry for it.
I will follow the guidelines. But will this PR be accepted or not?

@PratyushSingh07
Copy link
Collaborator

I will follow the guidelines. But is this PR valid or not.

Without following the proper guidelines this PR cannot be deemed valid

@SekhGulamMainuddin
Copy link
Contributor Author

SekhGulamMainuddin commented Oct 13, 2023

I will follow the guidelines. But is this PR valid or not.

Without following the proper guidelines this PR cannot be deemed valid

then what changes should I do?
Like should I add screenshots?

@PratyushSingh07
Copy link
Collaborator

you dont need to close the issue everytime @SekhGulamMainuddin . To change the commit message you can use the git commit --amend command and to change the PR message you can simply edit the PR text

@SekhGulamMainuddin
Copy link
Contributor Author

you dont need to close the issue everytime @SekhGulamMainuddin . To change the commit message you can use the git commit --amend command and to change the PR message you can simply edit the PR text

ok I will keep that in mind from next PR onwards. And follow the rules.

@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Oct 13, 2023

then what changes should I do? Like should I add screenshots?

I am not talking about the screenshots, please go through the wiki section and look at the manner in which you have to submit a PR. For instance, your commit message should have been feat #2365: hindi translations for mifos mobile"

@SekhGulamMainuddin
Copy link
Contributor Author

then what changes should I do? Like should I add screenshots?

I am not talking about the screenshots, please go through the wiki section and look at the manner in which you have to submit a PR. For instance, your commit message should have been feat #2365: hindi translations for mifos mobile"

OK I am changing the commit message.

@SekhGulamMainuddin
Copy link
Contributor Author

Thanks @PratyushSingh07 I have changed the commit message.

@SekhGulamMainuddin SekhGulamMainuddin changed the title Added Hindi Translated Strings Fix #2365 Added Hindi Translated Strings Oct 13, 2023
@PratyushSingh07 PratyushSingh07 changed the title Fix #2365 Added Hindi Translated Strings Feat: Added Hindi Translated Strings Oct 13, 2023
@PratyushSingh07
Copy link
Collaborator

It's more of a feat than a fix . It's ok for the time being but make sure to write proper prefixes while submitting a PR.

I have changed the PR message, follow the same for rest of your PRs

@SekhGulamMainuddin
Copy link
Contributor Author

Sure, I will follow the rules and guidelines.

@PratyushSingh07
Copy link
Collaborator

I have reviewed this PR @therajanmaurya , I believe this will be a good addition to our project

@therajanmaurya therajanmaurya merged commit 1b891a8 into openMF:development Oct 13, 2023
3 checks passed
@SekhGulamMainuddin
Copy link
Contributor Author

Hi @therajanmaurya can you please add hacktoberfest-accepted tag because its compulsory for Hacktoberfest Verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants