-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added Hindi Translated Strings #2376
Feat: Added Hindi Translated Strings #2376
Conversation
please follow our commit & PR guidelines . you can go through the wiki page here Follow the same in all of your PRs |
Sorry for it. |
Without following the proper guidelines this PR cannot be deemed valid |
then what changes should I do? |
you dont need to close the issue everytime @SekhGulamMainuddin . To change the commit message you can use the |
ok I will keep that in mind from next PR onwards. And follow the rules. |
I am not talking about the screenshots, please go through the wiki section and look at the manner in which you have to submit a PR. For instance, your commit message should have been feat #2365: hindi translations for mifos mobile" |
OK I am changing the commit message. |
a557176
to
1d7ec99
Compare
Thanks @PratyushSingh07 I have changed the commit message. |
It's more of a feat than a fix . It's ok for the time being but make sure to write proper prefixes while submitting a PR. I have changed the PR message, follow the same for rest of your PRs |
Sure, I will follow the rules and guidelines. |
I have reviewed this PR @therajanmaurya , I believe this will be a good addition to our project |
Hi @therajanmaurya can you please add |
Fixes #2365
Added Hindi Translations for the Strings.
Please add #hacktoberfest on merge.