Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Event Ratings #1204

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ gem 'mysql2'
# for observing records
gem 'rails-observers'

# for rating
gem 'ratyrate', github: 'wazery/ratyrate', branch: 'master'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I am really unsure about. The released version of ratyrate contains a bug in the rating_for_user method that shows a particular user's rating. This method is required for blind voting. However, the master is quite stable and does not contain the bug. This could be a temporary change until we get a response regarding wazery/ratyrate#125 ( issue asking for a new version release )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does using the gem from the master branch instead of the released version something we can agree upon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the gem from master:
ratyrate_gem

Using the released version:
rayrate

The function to show current_user's vote renders only a single star in the released version which has been fixed in master but a new version hasn't been released yet.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this master branch version you guys are talking about? I'm trying the master, but keep comes the alpha, is there another file to download?

I'm having a lot of issues with this gem for helper rating_for_user. I can't record at overrall_averages and average_cache tables, as long record the rater_id at rate table.
The method on this file is also comment:
https://github.com/wazery/ratyrate/blob/master/lib/ratyrate/model.rb

tks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the master branch is as simple as using this line above in the Gemfile. It would be great if we can discuss this more on the issue itself rather than here. 🙂


# for tracking data changes
gem 'paper_trail'

Expand Down
8 changes: 8 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
GIT
remote: git://github.com/wazery/ratyrate.git
revision: b738c56a4b53260d4083bbbc7895d7d32f3c0264
branch: master
specs:
ratyrate (1.2.2.alpha)

GEM
remote: https://rubygems.org/
remote: https://rails-assets.org/
Expand Down Expand Up @@ -611,6 +618,7 @@ DEPENDENCIES
rails-i18n (~> 4.0.0)
rails-observers
rails_12factor
ratyrate!
rdoc-generator-fivefish
redcarpet
responders (~> 2.0)
Expand Down
Binary file added app/assets/images/big-star.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/cancel-off.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/cancel-on.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/mid-star.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/star-half.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/star-off.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/star-on.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions app/assets/javascripts/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
//= require unobtrusive_flash_bootstrap
//= require countable
//= require selectize
//= require jquery.raty
//= require ratyrate
//= require osem-rating

$(document).ready(function() {
$('a[disabled=disabled]').click(function(event){
Expand Down
Loading