fix smpte drop-frame validation to only reject if seconds is '00' #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Apologies for the delay. Thank you for the PR, for catching this bug, and for using the lib! I am just catching up on some of my Repo's issues. This PR looks good to me, but the way I have my CI set up is that PR's should be made against dev, and the CI process adds some extra files that are comitted to main at the end of CI. Would you mind rebasing your PR to dev and the switch the branch you are merging into to the same? Thanks! |
|
I'd also appreciate if you added some new tests to validate the logic on our testing suite. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vtc.Timecode("00:01:01;00", rate=vtc.RATE.F29_97_DF)should be a valid timecode, but a ValueError is raised. This pull request corrects the validation.