Publish binaries and multi-arch docker images #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasRoesler
force-pushed
the
dockerize-certifier
branch
from
8471df6
to
a7df90b
Compare
|
@alexellis i don't think this is ready until we update the README with instructions on how to use the docker image, but i always get confused about the networking. Perhaps you have a suggestion on the right way to run it. For example, with docker swarm on your local machine, you can do docker run --network=func_functions openfaas/certifier:latest -gateway=http://func_gateway:8080But this presents an issue when running with auth, because you can just mount the local faas-cli config into the container because the gateway host names will be different, specifically, this doesn't work docker run -v $HOME/.openfaas:/home/default/.openfaas --network=func_functions openfaas/certifier:latest -gateway=http://func_gateway:8080 |
|
I can see a binary distribution being useful, what are the pros of having a Docker image along with that? |
LucasRoesler
force-pushed
the
dockerize-certifier
branch
2 times, most recently
from
f308a6b
to
cd34ffe
Compare
LucasRoesler
changed the title
**What** - Create a multiarch docker image that pre-compiles the certifier tests so that the tests are more portable - Update vendor folder to use latest openfaas projects - Add Github Actions workflow to publish Docker images and binaries on tags - reorganize CI scripts Signed-off-by: Lucas Roesler <[email protected]>
LucasRoesler
force-pushed
the
dockerize-certifier
branch
from
82ca122
to
9e0becf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
the tests are more portable
binaries on tags
Requires #58
Relates to #54
Relates to openfaas/faas#1585
Signed-off-by: Lucas Roesler [email protected]