Migrate builds to Github Actions #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Dec 11, 2020
alexellis
reviewed
Dec 11, 2020
utsavanand2
force-pushed
the
github-actions
branch
from
c2f61d0
to
d50ee3d
Compare
|
Resolved the previous issues with the PR. |
alexellis
reviewed
Mar 17, 2021
.github/workflows/publish.yml
Outdated
| name: Set Username/Repo and ImagePrefix as ENV vars | ||
| run: | | ||
| echo "USER_REPO"=$(echo "$GITHUB_REPOSITORY" | awk '{print tolower($1)}' | sed -e "s/:refs//") >> $GITHUB_ENV && \ | ||
| echo "IMAGE_PREFIX"=$(echo "ghcr.io/${{ github.repository_owner }}/queue-worker" | awk '{print tolower($1)}' | sed -e "s/:refs//") >> $GITHUB_ENV |
There was a problem hiding this comment.
IMAGE_PREFIX looks different to how we did this elsewhere? Can you make the example more consistent with faas-netes or faas?
|
@utsavanand2 I still need your help with this PR you created. It isn’t consistent with the other builds we have merged, can you go ahead and remove the IMAGE_PREFIX etc and make it work like the other builds we have merged? Thank you 🙏 |
|
Sure @alexellis will do this at the earliest |
|
How about this project as a template? |
Signed-off-by: Utsav Anand <[email protected]>
utsavanand2
force-pushed
the
github-actions
branch
from
d50ee3d
to
ffe78ae
Compare
|
We can't wait any longer for this, I'm closing it and taking it on myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Utsav Anand [email protected]
Description
Moves builds from Travis to Github Actions
Motivation and Context
- [ ] I have raised an issue to propose this change ([required]Issue 1585 for reference
(https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))
Move builds to Github Actions
How Has This Been Tested?
Check the build statuses:
build: https://github.com/utsavanand2/nats-queue-worker/runs/1536136986?check_suite_focus=true
publish: https://github.com/utsavanand2/nats-queue-worker/runs/1536224826?check_suite_focus=true
Types of changes
Checklist:
git commit -s