Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Standardise actions filenames and go version #231

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

Waterdrips
Copy link
Contributor

Description

This changes the name of "ci-only" action to build as per comments in
openfaas/faas#1585. Also pins go version
based on the same

Signed-off-by: Alistair Hey [email protected]

How Has This Been Tested?

see action on this PR

Checklist:

I have:

  • checked my changes follow the style of the existing code / OpenFaaS repos
  • updated the documentation and/or roadmap in README.md
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need Go on the host though?

This changes the name of "ci-only" action to build as per comments in
openfaas/faas#1585. Also pins go version
based on the same

Signed-off-by: Alistair Hey <[email protected]>
@Waterdrips
Copy link
Contributor Author

yeh, your right. no go version needed, built in docker

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit cb39f41 into openfaas:master Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants