-
Notifications
You must be signed in to change notification settings - Fork 229
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions
.github/workflows/ci-only.yml
Outdated
build: | ||
strategy: | ||
matrix: | ||
go-version: [1.9.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 1.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.github/workflows/ci-only.yml
Outdated
push: | ||
branches: [ "*" ] | ||
pull_request: | ||
branches: [ master ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, should we enable it for both push and pull request?
@wilsonianb could you advise re: pushing tags based upon the release version? |
You could do something like this (in an |
Signed-off-by: Nitishkumar Singh <[email protected]>
@wilsonianb Thank you sharing the example. @alexellis Can you please review it. |
@nitishkumar71 There's actually a lot more to converting ofc into actions than adding these workflows. As OFC is a complex system with lots of moving parts its probably best for me to take this over. |
makes sense |
Description
We want to migrate from Travis CI to Github Actions
Fixes #683
openfaas/faas#1585
How Has This Been Tested?
Please check CI Only Build
Please check Publish build for tag push
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s