Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Migrate Travis CI to Github Actions #684

Closed
wants to merge 1 commit into from
Closed

Migrate Travis CI to Github Actions #684

wants to merge 1 commit into from

Conversation

nitishkumar71
Copy link
Member

@nitishkumar71 nitishkumar71 commented Nov 7, 2020

Description

We want to migrate from Travis CI to Github Actions
Fixes #683
openfaas/faas#1585

How Has This Been Tested?

Please check CI Only Build
Please check Publish build for tag push

How are existing users impacted? What migration steps/scripts do we need?

  1. We are not able to run CI Pipelines
  2. We are moving to github actions for CI Pipelines

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

@derek
Copy link

derek bot commented Nov 7, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions

build:
strategy:
matrix:
go-version: [1.9.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1.13

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

push:
branches: [ "*" ]
pull_request:
branches: [ master ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should we enable it for both push and pull request?

@derek derek bot removed the no-dco label Nov 7, 2020
@alexellis
Copy link
Member

@wilsonianb could you advise re: pushing tags based upon the release version?

@wilsonianb
Copy link
Contributor

You could do something like this (in an on.tag workflow) for the non-function components and use ${{ github.ref }} for the image tags:
https://github.com/wilsonianb/openfaas-cloud/blob/dfc967a49eca9acd099afc02138d96607ea4332b/.github/workflows/docker.yml#L34-L57

@nitishkumar71
Copy link
Member Author

You could do something like this (in an on.tag workflow) for the non-function components and use ${{ github.ref }} for the image tags:
https://github.com/wilsonianb/openfaas-cloud/blob/dfc967a49eca9acd099afc02138d96607ea4332b/.github/workflows/docker.yml#L34-L57

@wilsonianb Thank you sharing the example.

@alexellis Can you please review it.

@Waterdrips
Copy link
Contributor

@nitishkumar71 There's actually a lot more to converting ofc into actions than adding these workflows. As OFC is a complex system with lots of moving parts its probably best for me to take this over.

@Waterdrips Waterdrips mentioned this pull request Nov 12, 2020
4 tasks
@nitishkumar71
Copy link
Member Author

@nitishkumar71 There's actually a lot more to converting ofc into actions than adding these workflows. As OFC is a complex system with lots of moving parts its probably best for me to take this over.

makes sense

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Travis to Github Actions
4 participants