Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to Github Actions #133

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

nitishkumar71
Copy link
Member

@nitishkumar71 nitishkumar71 commented Dec 5, 2020

Signed-off-by: Nitishkumar Singh [email protected]

Description

We want to migrate from Travis CI to Github Actions
Fixes openfaas/faas#1585
How Has This Been Tested?

Please check CI Only Build

@alexellis
Copy link
Member

Hi, I've checked the PR and I don't think this is right, it says the testing of the images took 16s - it should be much longer. Can you compare it to the Travis build?

Please can you look into it?

@nitishkumar71
Copy link
Member Author

Sure, I will look into it.

@nitishkumar71
Copy link
Member Author

nitishkumar71 commented Dec 9, 2020

@alexellis So just looked into it. The entire travis build takes 40 seconds, but the script execution takes around 16-20 seconds.

just checked the time taken to execute each step in job log of few of previous pull request, they are also near by in execution duration

https://travis-ci.com/github/openfaas/store/builds/147624170
https://travis-ci.com/github/openfaas/store/builds/147624170
https://travis-ci.com/github/openfaas/store/builds/159423705

Signed-off-by: Nitishkumar Singh <[email protected]>

updated readme

Signed-off-by: Nitishkumar Singh <[email protected]>

added echo for image done

Signed-off-by: Nitishkumar Singh <[email protected]>

removed additional echo

Signed-off-by: Nitishkumar Singh <[email protected]>
@alexellis alexellis merged commit 536cadd into openfaas:master Jan 21, 2021
@alexellis
Copy link
Member

@nitishkumar71 thanks for confirming. I'll get this merged then.

Can you confirm if the build passes in master?

@nitishkumar71
Copy link
Member Author

@nitishkumar71 thanks for confirming. I'll get this merged then.

Can you confirm if the build passes in master?

@alexellis the build passed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions Migration - tracking issue
2 participants