Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about enabling logs in production to logging documentation #776

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Siddhant-K-code
Copy link
Contributor

Description

This PR updates the logging documentation to include an important warning about enabling logs in production environments. Disabling logging by setting --log-level to none can mask important operations and hinder the ability to detect and diagnose issues, including potential security incidents.

References

Related openfga/openfga#1703

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@Siddhant-K-code
Copy link
Contributor Author

🫠

image

@rhamzeh
Copy link
Member

rhamzeh commented Jun 23, 2024

Thanks @Siddhant-K-code !

(Don't worry about the failing PR - PR Previews only work for branches in the repo)

Once another maintainer approves, we can merge

@Siddhant-K-code Siddhant-K-code deleted the patch-1 branch June 25, 2024 16:09
@Siddhant-K-code Siddhant-K-code restored the patch-1 branch June 26, 2024 11:58
@Siddhant-K-code
Copy link
Contributor Author

How does this PR got closed 🤔

@rhamzeh rhamzeh enabled auto-merge (squash) June 26, 2024 21:09
@rhamzeh rhamzeh disabled auto-merge June 26, 2024 21:09
@rhamzeh rhamzeh enabled auto-merge (squash) June 26, 2024 21:09
@rhamzeh rhamzeh merged commit f54ef4c into openfga:main Jun 26, 2024
12 of 14 checks passed
@Siddhant-K-code Siddhant-K-code deleted the patch-1 branch July 3, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants