Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Some existing problems with openkf are optimized #223

Merged
merged 5 commits into from
Apr 8, 2024
Merged

feat: Some existing problems with openkf are optimized #223

merged 5 commits into from
Apr 8, 2024

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Mar 23, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 23, 2024
@cubxxw cubxxw marked this pull request as draft March 23, 2024 06:33
@cubxxw cubxxw marked this pull request as ready for review March 23, 2024 06:44
@cubxxw cubxxw marked this pull request as draft March 23, 2024 06:44
IRONICBo
IRONICBo approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cubxxw cubxxw changed the title 【TODO】 feat: Some existing problems with openkf are optimized Apr 8, 2024
@cubxxw cubxxw marked this pull request as ready for review April 8, 2024 14:50
@cubxxw cubxxw merged commit 621c15c into openimsdk:main Apr 8, 2024
7 of 12 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IRONICBo IRONICBo IRONICBo approved these changes

@kubbot kubbot Awaiting requested review from kubbot kubbot is a code owner

@eurecalulu eurecalulu Awaiting requested review from eurecalulu eurecalulu is a code owner

@liumingsongning liumingsongning Awaiting requested review from liumingsongning liumingsongning is a code owner

@Cathay-Chen Cathay-Chen Awaiting requested review from Cathay-Chen Cathay-Chen is a code owner

@fodedoumbouya fodedoumbouya Awaiting requested review from fodedoumbouya fodedoumbouya is a code owner

@tobehardest tobehardest Awaiting requested review from tobehardest tobehardest is a code owner

@StellarisW StellarisW Awaiting requested review from StellarisW StellarisW is a code owner

@linesoft2 linesoft2 Awaiting requested review from linesoft2 linesoft2 is a code owner

@MC-kanon MC-kanon Awaiting requested review from MC-kanon MC-kanon is a code owner

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner automatically assigned from openimsdk/openim

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner automatically assigned from openimsdk/openim

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cubxxw @IRONICBo