Add rolling version upgrade support for ignore_unmapped #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Kotwani <[email protected]>
kotwanikunal
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
|
@kotwanikunal thanks for raising the PR. Will wait for all BWC to gh actions to complete. |
|
@kotwanikunal can you fix the failed GH actions? |
|
Good finding, we should do same in other repos. Will approve once CI is fixed. Current error is from spotless, you can run |
Signed-off-by: Kunal Kotwani <[email protected]>
|
Pushed linting fixes in. |
|
Looks related to the change. Let me take a look |
shatejas
reviewed
Jul 3, 2024
| @@ -324,7 +326,7 @@ protected void doWriteTo(StreamOutput out) throws IOException { | |||
| out.writeFloatArray(vector); | |||
| out.writeInt(k); | |||
| out.writeOptionalNamedWriteable(filter); | |||
| if (isClusterOnOrAfterMinRequiredVersion("ignore_unmapped")) { | |||
| if (out.getVersion().onOrAfter(getMinVersionForFeature("ignore_unmapped"))) { | |||
There was a problem hiding this comment.
Does this stream guarantee the min version of the cluster. Just verifying since the previous method has that check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ignore_unmappedIssues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.