[feature/ef-search -> main] Adds Nprobe as a query parameter in knn query #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
shatejas
force-pushed
the
main
branch
2 times, most recently
from
82e95d8
to
b857823
Compare
jmazanec15
reviewed
Jul 5, 2024
Happens in doToQuery(). It will throw an exception if there there is no context found |
shatejas
changed the title
|
If I understand correctly, these changes are already in the feature branch? |
Thats correct. I have linked the original Prs in the description |
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]>
Signed-off-by: Tejas Shah <[email protected]>
navneet1v
approved these changes
Jul 16, 2024
navneet1v
added
backport 2.x
Features
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1792-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4224661f3ad1a01a4fdd77e835af08ce2f0aa48
# Push it to GitHub
git push --set-upstream origin backport/backport-1792-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 16, 2024
…) (opensearch-project#1792) Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]> (cherry picked from commit b422466)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration test for invalid method parameters (#1782)
Description
Adds nprobes as a query parameter
This is cherry-picked from feature branch to main. Original PRs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.