Fix login redirect (#777)

opensearch-project · Jun 2, 2021 · 46c93f3 · 46c93f3
1 parent 35054f6
commit 46c93f3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/public/apps/account/utils.tsx b/public/apps/account/utils.tsx
@@ -14,7 +14,7 @@
  */
 
 import { HttpStart } from 'opensearch-dashboards/public';
-import { API_AUTH_LOGOUT } from '../../../common';
+import { API_AUTH_LOGOUT, LOGIN_PAGE_URI } from '../../../common';
 import { API_ENDPOINT_ACCOUNT_INFO } from './constants';
 import { AccountInfo } from './types';
 import { httpGet, httpGetWithIgnores, httpPost } from '../configuration/utils/request-utils';
@@ -31,7 +31,9 @@ export async function fetchAccountInfoSafe(http: HttpStart): Promise<AccountInfo
 export async function logout(http: HttpStart, logoutUrl?: string): Promise<void> {
   await httpPost(http, API_AUTH_LOGOUT);
   setShouldShowTenantPopup(null);
-  window.location.href = logoutUrl || `${http.basePath.serverBasePath}/app/login`;
+  const nextUrl = encodeURIComponent(http.basePath.serverBasePath);
+  window.location.href =
+    logoutUrl || `${http.basePath.serverBasePath}/app/login?nextUrl=${nextUrl}`;
 }
 
 export async function updateNewPassword(

diff --git a/release-notes/opensearch-security-dashboards-plugin.release-notes-1.0.0.0-rc1.md b/release-notes/opensearch-security-dashboards-plugin.release-notes-1.0.0.0-rc1.md
@@ -6,6 +6,7 @@
 
 ### Bug Fixes
 * Fixing JSON parsing in SAML for strings that contain '\' character [#749](https://github.com/opensearch-project/security-dashboards-plugin/pull/749)
+* Fix login redirect [#777](https://github.com/opensearch-project/security-dashboards-plugin/pull/777)
 
 ### Maintenance
 * move issue templates to ISSUE_TEMPLATE [#758](https://github.com/opensearch-project/security-dashboards-plugin/pull/758)

diff --git a/server/auth/types/basic/routes.ts b/server/auth/types/basic/routes.ts
@@ -178,7 +178,7 @@ export class BasicAuthRoutes {
             );
             return response.redirected({
               headers: {
-                location: `${this.coreSetup.http.basePath.serverBasePath}${LOGIN_PAGE_URI}`,
+                location: `${this.coreSetup.http.basePath.serverBasePath}`,
               },
             });
           }
@@ -214,7 +214,7 @@ export class BasicAuthRoutes {
           );
           return response.redirected({
             headers: {
-              location: `${this.coreSetup.http.basePath.serverBasePath}${LOGIN_PAGE_URI}`,
+              location: `${this.coreSetup.http.basePath.serverBasePath}`,
             },
           });
         }