Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce opensearch_security.configuration.admin_pages_enabled setting to be able to disable security admin pages #1963

Closed

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 17, 2024

Description

Introduces an opensearch_dashboards.yml setting to be able to disable Security from the menu for all users. The setting is opensearch_security.configuration.admin_pages_enabled, is true by default and needs to be explicitly disabled.

Currently, the behavior is to display Security in the main menu only for a Security admin user. To determine whether a user is a Security admin, security-dashboards-plugin runs an API request and determines if the logged in user is mapped to one of the plugins.security.restapi.roles_enabled roles.

Category

Enhancement

Issues Resolved

Testing

Manual testing to ensure disabling the Security screens doesn't cause any other issues. The user still needs to be able to reset their password, view their user info and switch tenants.

Marking this as Draft until functional tests are added.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ng to be able to disable security admin pages

Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 31.03448% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 69.94%. Comparing base (37c2695) to head (002b3d3).
Report is 1 commits behind head on main.

Files Patch % Lines
public/plugin.ts 31.03% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   69.91%   69.94%   +0.03%     
==========================================
  Files          97       96       -1     
  Lines        2506     2519      +13     
  Branches      336      351      +15     
==========================================
+ Hits         1752     1762      +10     
- Misses        673      674       +1     
- Partials       81       83       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant