[WIP] MGMT-18561: MGMT-18562: Add kube api support for adding mirror registry in agent cluster install

[eliorerz]

/cc @eliorerz

[openshift-ci-robot]

@eliorerz: This pull request references MGMT-18561 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

/cc @eliorerz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @eliorerz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [eliorerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 61.84739% with 95 lines in your changes missing coverage. Please review.

Project coverage is 68.66%. Comparing base (cd37030) to head (3599097).

❗ Current head 3599097 differs from pull request most recent head ffc0a0d

Please upload reports for the commit ffc0a0d to get more accurate results.

Files with missing lines	Patch %	Lines
pkg/mirrorregistries/cluster_image_registry.go	41.97%	45 Missing and 2 partials ⚠️
internal/installcfg/builder/builder.go	67.79%	13 Missing and 6 partials ⚠️
...oller/controllers/clusterdeployments_controller.go	70.00%	6 Missing and 3 partials ⚠️
internal/ignition/discovery.go	66.66%	5 Missing and 3 partials ⚠️
...rnal/controller/controllers/infraenv_controller.go	50.00%	2 Missing and 2 partials ⚠️
pkg/mirrorregistries/generator.go	66.66%	4 Missing ⚠️
internal/bminventory/inventory.go	92.30%	0 Missing and 2 partials ⚠️
...ler/controllers/preprovisioningimage_controller.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6868      +/-   ##
==========================================
- Coverage   68.73%   68.66%   -0.07%     
==========================================
  Files         249      250       +1     
  Lines       37439    37593     +154     
==========================================
+ Hits        25734    25815      +81     
- Misses       9405     9469      +64     
- Partials     2300     2309       +9     

Files with missing lines	Coverage Δ
internal/bminventory/inventory_v2_handlers.go	56.60% <100.00%> (ø)
internal/oc/release.go	73.51% <100.00%> (ø)
internal/bminventory/inventory.go	70.70% <92.30%> (ø)
...ler/controllers/preprovisioningimage_controller.go	81.43% <50.00%> (-0.39%)	⬇️
...rnal/controller/controllers/infraenv_controller.go	63.57% <50.00%> (-0.33%)	⬇️
pkg/mirrorregistries/generator.go	62.50% <66.66%> (-2.09%)	⬇️
internal/ignition/discovery.go	74.24% <66.66%> (+0.43%)	⬆️
...oller/controllers/clusterdeployments_controller.go	71.67% <70.00%> (-0.19%)	⬇️
internal/installcfg/builder/builder.go	80.10% <67.79%> (-2.82%)	⬇️
pkg/mirrorregistries/cluster_image_registry.go	41.97% <41.97%> (ø)

... and 2 files with indirect coverage changes

[eliorerz]

/test edge-subsystem-kubeapi-aws

[openshift-ci]

@eliorerz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-subsystem-kubeapi-aws	ffc0a0d	link	true	/test edge-subsystem-kubeapi-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.