MGMT-19057: Add OpenShift AI skeleton #6872

jhernand · 2024-10-07T16:52:44Z

This patch adds the skeleton for the new OpenShift AI monitored operator. With this it is possible to install the operator, but without dependencies or configuration. That will be added in later patches.

List all the issues related to this PR

Related: https://issues.redhat.com/browse/MGMT-19057

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Tested manually installing a cluster and checking that the operator is installed.

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci-robot · 2024-10-07T16:52:48Z

openshift-ci · 2024-10-07T16:53:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

internal/featuresupport/common.go

internal/operators/oai/oai_operator.go

danmanor · 2024-10-07T17:20:15Z

internal/operators/oai/oai_operator.go

+		}
+		return
+	}
+	minVersion, err := version.NewVersion(o.config.MinOpenShiftVersion)


Why do we need validate here and in featureSupport as well ?

I don't have a good answer for that, will check.

codecov · 2024-10-07T17:28:17Z

Codecov Report

Attention: Patch coverage is 69.38776% with 75 lines in your changes missing coverage. Please review.

Project coverage is 68.74%. Comparing base (cd37030) to head (a416d79).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/operators/oai/oai_operator.go	60.92%	51 Missing and 8 partials ⚠️
internal/operators/oai/manifest.go	72.97%	5 Missing and 5 partials ⚠️
internal/featuresupport/features_olm_operators.go	71.42%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #6872    +/-   ##
========================================
  Coverage   68.73%   68.74%            
========================================
  Files         249      252     +3     
  Lines       37439    37683   +244     
========================================
+ Hits        25734    25905   +171     
- Misses       9405     9464    +59     
- Partials     2300     2314    +14

Files with missing lines	Coverage Δ
internal/cluster/statemachine.go	`99.64% <100.00%> (+<0.01%)`	⬆️
internal/cluster/validation_id.go	`92.30% <100.00%> (ø)`
internal/featuresupport/feature_support_level.go	`96.49% <ø> (ø)`
internal/host/statemachine.go	`100.00% <100.00%> (ø)`
internal/host/validation_id.go	`90.90% <100.00%> (ø)`
internal/operators/builder.go	`100.00% <100.00%> (ø)`
internal/operators/oai/test_utils.go	`100.00% <100.00%> (ø)`
internal/featuresupport/features_olm_operators.go	`86.74% <71.42%> (-2.22%)`	⬇️
internal/operators/oai/manifest.go	`72.97% <72.97%> (ø)`
internal/operators/oai/oai_operator.go	`60.92% <60.92%> (ø)`

... and 3 files with indirect coverage changes

danmanor · 2024-10-08T06:55:28Z

@jhernand Do we want to add a CI test for testing it ?

jhernand · 2024-10-08T07:12:04Z

@jhernand Do we want to add a CI test for testing it ?

Yes, I think eventually we will want to have CI tests. But I think is too soon for that; I think it is better to wait till we have the dependencies and the configuration, which will go in other patches.

jhernand · 2024-10-08T07:22:32Z

/hold

internal/operators/oai/oai_operator.go

CrystalChun

Looks good to me! Will wait for Dan's comments

CrystalChun · 2024-10-08T15:46:52Z

Maybe one suggestion is to add doc for this? At least the requirements for it and maybe how to specify in a cluster that you want this operator?

danmanor · 2024-10-09T07:31:50Z

/retest

jhernand · 2024-10-09T09:16:52Z

Maybe one suggestion is to add doc for this? At least the requirements for it and maybe how to specify in a cluster that you want this operator?

Yes @CrystalChun, that makes sense. I added a section to the operators document in the user guide. Easier to read here: https://github.com/jhernand/assisted-service/blob/add_rhoai_operator/docs/user-guide/additional-operator-notes.md#openshift-ai

This patch adds the skeleton for the new _OpenShift AI_ monitored operator. With this it is possible to install the operator, but without dependencies or configuration. That will be added in later patches. Related: https://issues.redhat.com/browse/MGMT-19057 Signed-off-by: Juan Hernandez <[email protected]>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2024

openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2024

openshift-ci bot requested review from CrystalChun and danmanor October 7, 2024 16:53

openshift-ci bot added the api-review Categorizes an issue or PR as actively needing an API review. label Oct 7, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024

danmanor reviewed Oct 7, 2024

View reviewed changes

internal/featuresupport/common.go Outdated Show resolved Hide resolved

danmanor reviewed Oct 7, 2024

View reviewed changes

internal/operators/oai/oai_operator.go Show resolved Hide resolved

danmanor reviewed Oct 7, 2024

View reviewed changes

jhernand force-pushed the add_rhoai_operator branch 2 times, most recently from c5e8234 to 6fcf9a3 Compare October 7, 2024 19:19

jhernand force-pushed the add_rhoai_operator branch from 6fcf9a3 to a19f4d5 Compare October 8, 2024 07:21

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2024

jhernand force-pushed the add_rhoai_operator branch 3 times, most recently from e1ad504 to 2b26d19 Compare October 8, 2024 12:56

CrystalChun reviewed Oct 8, 2024

View reviewed changes

internal/operators/oai/oai_operator.go Outdated Show resolved Hide resolved

CrystalChun reviewed Oct 8, 2024

View reviewed changes

jhernand force-pushed the add_rhoai_operator branch from 2b26d19 to 11f559d Compare October 8, 2024 14:00

jhernand force-pushed the add_rhoai_operator branch 3 times, most recently from fd53bee to a97be0b Compare October 9, 2024 09:15

jhernand force-pushed the add_rhoai_operator branch 2 times, most recently from 3460c6f to 3b1ad36 Compare October 9, 2024 09:19

jhernand force-pushed the add_rhoai_operator branch from 3b1ad36 to a416d79 Compare October 9, 2024 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MGMT-19057: Add OpenShift AI skeleton #6872

MGMT-19057: Add OpenShift AI skeleton #6872

jhernand commented Oct 7, 2024

openshift-ci-robot commented Oct 7, 2024 •

edited by openshift-ci bot

Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci bot commented Oct 7, 2024

danmanor Oct 7, 2024

jhernand Oct 7, 2024

codecov bot commented Oct 7, 2024 •

edited

Loading

danmanor commented Oct 8, 2024

jhernand commented Oct 8, 2024

jhernand commented Oct 8, 2024

CrystalChun left a comment

CrystalChun commented Oct 8, 2024

danmanor commented Oct 9, 2024

jhernand commented Oct 9, 2024

MGMT-19057: Add OpenShift AI skeleton #6872

Are you sure you want to change the base?

MGMT-19057: Add OpenShift AI skeleton #6872

Conversation

jhernand commented Oct 7, 2024

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Oct 7, 2024 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci bot commented Oct 7, 2024

danmanor Oct 7, 2024

Choose a reason for hiding this comment

jhernand Oct 7, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 7, 2024 • edited Loading

Codecov Report

danmanor commented Oct 8, 2024

jhernand commented Oct 8, 2024

jhernand commented Oct 8, 2024

CrystalChun left a comment

Choose a reason for hiding this comment

CrystalChun commented Oct 8, 2024

danmanor commented Oct 9, 2024

jhernand commented Oct 9, 2024

openshift-ci-robot commented Oct 7, 2024 •

edited by openshift-ci bot

Loading

codecov bot commented Oct 7, 2024 •

edited

Loading