Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-6084: Refactor internal model #2791

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

LOG-6084: Refactor internal model #2791

wants to merge 14 commits into from

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Sep 4, 2024 •
edited
Loading

Description

This PR:

  • replaces ViaQ with an internal model (made up of Viaq bits)
  • Formats entries to ViaQ as postfilter to allow fields to be consinstently available for filtering and output needs
  • prepares for 6.1 to write to LokiStack OTLP

Links

@jcantrill
Copy link
Contributor Author

/hold

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@jcantrill
Copy link
Contributor Author

/retest

4 similar comments
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/test functional-target

@jcantrill
Copy link
Contributor Author

/test functional-target

2 similar comments
@jcantrill
Copy link
Contributor Author

/test functional-target

@jcantrill
Copy link
Contributor Author

/test functional-target

@jcantrill jcantrill changed the title Refactor internal model LOG-6084: Refactor internal model Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@jcantrill: This pull request references LOG-6084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • replaces ViaQ with an internal model (made up of Viaq bits)
  • Formats entries to ViaQ as postfilter to allow fields to be consinstently available for filtering and output needs
  • prepares for 6.1 to write to LokiStack OTLP

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/retest

1 similar comment
@jcantrill
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target 8437856 link true /test functional-target
ci/prow/unit 8437856 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahartma cahartma Awaiting requested review from cahartma

@Clee2691 Clee2691 Awaiting requested review from Clee2691

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. release/6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcantrill @openshift-ci-robot @openshift-merge-robot