-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-6128: Fix console plugin api version #2805
base: release-5.9
Are you sure you want to change the base?
LOG-6128: Fix console plugin api version #2805
Conversation
@jgbernalp: This pull request references LOG-6128 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3af181b
to
e98f1e2
Compare
New changes are detected. LGTM label has been removed. |
Signed-off-by: Gabriel Bernal <[email protected]>
e98f1e2
to
6abb572
Compare
@jgbernalp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Must we fix it? |
/hold |
Description
From OCP v4.17+, the ConsolePlugin v1alpha1 was deprecated in favor of ConsolePlugin v1. This causes the logging plugin to fail during reconciliation as the new version of the spec needs for 4.17+. This PR adds support for ConsolePlugin v1 when the operator is running on clusters with v4.17+
This is targeted directly to the 5.9 branch as 6.0 (master) has removed the console plugin
/cc @jcantrill
/assign @alanconway
Links