Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Rename efscreate package #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenfin
Copy link
Contributor

Align with the name of the binary as is done for everything else.

Signed-off-by: Stephen Finucane [email protected]

Align with the name of the binary as is done for everything else.

Signed-off-by: Stephen Finucane <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stephenfin
Copy link
Contributor Author

/retitle: NO-JIRA: Rename efscreate package

@openshift-ci openshift-ci bot changed the title trivial: Rename efscreate package : NO-JIRA: Rename efscreate package Sep 26, 2024
@openshift-ci-robot
Copy link

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

Align with the name of the binary as is done for everything else.

Signed-off-by: Stephen Finucane [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2024
@stephenfin stephenfin changed the title : NO-JIRA: Rename efscreate package NO-JIRA: Rename efscreate package Sep 26, 2024
@gnufied
Copy link
Member

gnufied commented Sep 26, 2024

I think if we do this, we will have to update how we run e2e tests for efs driver too in openshift/release repo.

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade beb225a link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-cinder-csi beb225a link true /test e2e-openstack-cinder-csi
ci/prow/hypershift-aws-e2e-external beb225a link true /test hypershift-aws-e2e-external
ci/prow/e2e-azure-file-csi beb225a link true /test e2e-azure-file-csi
ci/prow/e2e-azurestack-csi beb225a link false /test e2e-azurestack-csi
ci/prow/e2e-openstack-manila-csi beb225a link true /test e2e-openstack-manila-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants