Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: OLS-449: Operator deploys postgres image #385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: OLS-449: Operator deploys postgres image #385

wants to merge 1 commit into from

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Sep 9, 2024 •
edited
Loading

Description

Integrate PostgreSQL as a conversation cache

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raptorsun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@syedriko syedriko changed the title WIP: PostgreSQL integration WIP: OLS-449: Operator deploys postgres image Sep 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-449 which is a valid jira issue.

In response to this:

Description

Integrate PostgreSQL as a conversation cache

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-449 which is a valid jira issue.

In response to this:

Description

Integrate PostgreSQL as a conversation cache

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2024
@syedriko syedriko force-pushed the syedriko-postgres branch 2 times, most recently from 8b715b5 to c07a553 Compare September 16, 2024 22:42
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@syedriko syedriko force-pushed the syedriko-postgres branch 2 times, most recently from a31c7d7 to fb3d7a9 Compare September 18, 2024 20:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@syedriko
Copy link
Contributor Author

/retest

@syedriko
Copy link
Contributor Author

syedriko commented Sep 19, 2024 •
edited
Loading

@vishnuchalla Could you review this? It's a rebase of #108 to the tip of main, with registry.redhat.io/rhel9/postgresql-16 for the Postgres image and whatever fixes were needed to get it to work.

@vishnuchalla
Copy link
Contributor

Sure. Will take some time out for this before end of this week.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@syedriko
Copy link
Contributor Author

@vishnuchalla could you take a look at this, please?

@vishnuchalla
Copy link
Contributor

@vishnuchalla could you take a look at this, please?

@syedriko looks good to me maybe because most of it's content is same as my previous PR, so everything is according to the plan of execution I thought. I would recommend an another set of eyes on this.

@vishnuchalla vishnuchalla mentioned this pull request Sep 26, 2024
Closed
11 tasks
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 26, 2024

@syedriko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-17 7c4b826 link true /test bundle-e2e-4-17

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raptorsun raptorsun Awaiting requested review from raptorsun

@vbelouso vbelouso Awaiting requested review from vbelouso

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syedriko @openshift-ci-robot @vishnuchalla @openshift-merge-robot