Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLS-1058 - Adding OLS e2e tests #416

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OLS-1058 - Adding OLS e2e tests #416

wants to merge 3 commits into from

Conversation

JoaoFula
Copy link
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@JoaoFula
Adding OLS e2e tests
f3908b8 
Adding OLS e2e tests
@JoaoFula JoaoFula force-pushed the konflux-adding-test branch 3 times, most recently from d519a73 to dfb52a6 Compare September 18, 2024 09:57
@JoaoFula
Adding kubeconfig
3e8e985 
Adding kubeconfig

Adding kubeconfig

Adding kubeconfig

Adding kubeconfig
@JoaoFula JoaoFula force-pushed the konflux-adding-test branch 15 times, most recently from a49133a to 03839f2 Compare September 25, 2024 12:58
@JoaoFula JoaoFula force-pushed the konflux-adding-test branch 5 times, most recently from 2991531 to 5c232e8 Compare September 26, 2024 11:39
@raptorsun
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@raptorsun
Copy link
Contributor

/override "Red Hat Konflux / ols-enterprise-contract / test-bundle"
/override "Red Hat Konflux / ols-enterprise-contract / bundle"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 26, 2024

@raptorsun: Overrode contexts on behalf of raptorsun: Red Hat Konflux / ols-enterprise-contract / bundle, Red Hat Konflux / ols-enterprise-contract / test-bundle

In response to this:

/override "Red Hat Konflux / ols-enterprise-contract / test-bundle"
/override "Red Hat Konflux / ols-enterprise-contract / bundle"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 27, 2024

New changes are detected. LGTM label has been removed.

onmete
onmete reviewed Sep 30, 2024
View reviewed changes
.tekton/integration-tests/pipelines/lightspeed-integration-test-pipeline.yaml
make install-deps
make install-deps-test
pdm run pytest tests/e2e -s --durations=0 -o junit_suite_name="${SUITE_ID}" -m "${TEST_TAGS}" --junit-prefix="${SUITE_ID}" --junit-xml="${ARTIFACT_DIR}/junit_e2e_${SUITE_ID}.xml" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make test-e2e?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test-e2e was causing a bunch of dependency issues:
python not installed
pytest not installed
ReportPortalClient not installed
Basically everything that was dependent on pdm was not working. So, due to the short timeframe we have for this, I decided to add the pdm run pytest ...

@JoaoFula JoaoFula force-pushed the konflux-adding-test branch 8 times, most recently from 89b996c to 936ff7e Compare October 3, 2024 12:28
@JoaoFula JoaoFula force-pushed the konflux-adding-test branch 4 times, most recently from 8654506 to 1145ed8 Compare October 7, 2024 14:06
@JoaoFula
Attempting to fix image reference issue
9052a52 
Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Attempting to fix image reference issue

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding 4.17 cluster pool for ols

Adding OLS installation via operator-sdk to work in konflux

Adding OLS installation via operator-sdk to work in konflux

Adding exception to operator installation for konflux

Adding exception to operator installation for konflux

Adding exception to operator installation for konflux

Adding exception to operator installation for konflux

Adding exception to operator installation for konflux

Adding exception to operator installation for konflux

Adding exception to operator installation for konflux

Adding operator tests for 4.15 and 4.17

Adding operator tests for 4.15 and 4.17

Adding operator tests for 4.15 and 4.17

Adding operator tests for 4.15 and 4.17

Adding operator tests for 4.15 and 4.17

Removing the get
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 8, 2024

@JoaoFula: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onmete onmete onmete left review comments

@dheerajodha dheerajodha dheerajodha left review comments

@bparees bparees Awaiting requested review from bparees

@vbelouso vbelouso Awaiting requested review from vbelouso

Assignees

@raptorsun raptorsun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoaoFula @raptorsun @onmete @dheerajodha